RFR: JDK-8224594: Simplify jpackage Logging

[Alexey Semenyuk]

Looks good.

- Alexey

On 8/15/2019 4:50 PM, Andy Herrick wrote:
> ok - revised [3] to restore the second trace statement (now 
> Log.verbose())
>
> [3]: http://cr.openjdk.java.net/~herrick/8224594/webrev.02/
>
> /Andy
>
> On 8/15/2019 3:40 PM, Andy Herrick wrote:
>> The first of these doesn't convey any additional information, since 
>> it is just parroting back the given option value.
>>
>> The second may be of use, and I could restore it as a Log.verbose(), 
>> but I felt the output here was incomplete, and would be better served 
>> by tracing in the caller, since this is the value returned, and the 
>> caller (either MacAppBundler, MacPkgBundler, or MacAppBundler) could 
>> say what the key was being used for, and if the certificate derived 
>> from this key was valid.
>>
>> In general is a fine line to decide what to include in verbose output.
>>
>> We used to have both debug and verbose output, but other than 
>> printing out exceptions, theses two and one other were the only 
>> places actually calling Log.debug()
>>
>> /Andy
>>
>> On 8/15/2019 3:09 PM, Alexey Semenyuk wrote:
>>> Andy,
>>>
>>> What is the reason to remove log statements in
>>> http://cr.openjdk.java.net/~herrick/8224594/webrev.01/src/jdk.jpackage/share/classes/jdk/jpackage/internal/StandardBundlerParam.java.sdiff.html 
>>>
>>> http://cr.openjdk.java.net/~herrick/8224594/webrev.01/src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/MacBaseInstallerBundler.java.sdiff.html 
>>>
>>>
>>> ?
>>>
>>> - Alexey
>>>
>>> On 8/15/2019 2:53 PM, Andy Herrick wrote:
>>>> Please review the jpackage fix for bug [1] at [2].
>>>>
>>>> This is a fix for the JDK-8200758-branch branch of the open sandbox 
>>>> repository (jpackage).
>>>>
>>>> [1] https://bugs.openjdk.java.net/browse/JDK-8224594
>>>>
>>>> [2] http://cr.openjdk.java.net/~herrick/8224594/
>>>>
>>>>
>>>> Thanks,
>>>>
>>>> Andy
>>>>
>>>