RFR: JDK-8139820: URLClassPath.FileLoader constructor redundantly checks protocol

Claes Redestad claes.redestad at oracle.com
Sun Aug 18 22:18:46 UTC 2019


Hi,

On 2019-08-18 21:22, Evgeny Mandrikov wrote:
> [1] https://cr.openjdk.java.net/~godin/8139820/webrev.00/

looks ok to me.

I'd add a comment that protocol is assumed to be "file", and perhaps
make the constructor private (valid since JDK 11).

I can sponsor the change, seeing how I apperently filed and then
completely forgot about this cleanup.. :-)

Thanks!

/Claes


More information about the core-libs-dev mailing list