RFR: JDK-8229795: Investigate registry key usage and need for --win-registry-name option.

Alexander Matveev alexander.matveev at oracle.com
Mon Aug 19 21:44:56 UTC 2019


Looks good.

Thanks,
Alexander

On 8/19/2019 2:16 PM, Kevin Rushforth wrote:
> OK. Looks good.
>
> -- Kevin
>
>
> On 8/19/2019 2:09 PM, Andy Herrick wrote:
>>
>> On 8/19/19 4:53 PM, Kevin Rushforth wrote:
>>> The following will take the last in the list of extensions and use 
>>> that:
>>>
>>> + entryName = ext.toUpperCase() + "File";
>> entryName is both set and used within the "for (String ext : 
>> extensions)" block.
>>>
>>>
>>> Also, did you mean to upper-case the extension? I note that "File" 
>>> isn't upper-case, nor is the prefix when there isn't an extension.
>>
>> yes - I meant that - my example was "JNLPFile" we use as name of 
>> "jnlp" association we use in webstart.
>>
>> I have no example of mime-type association without any file 
>> extensions, so was just using the name as is.
>>
>> /Andy
>>
>>>
>>> -- Kevin
>>>
>>>
>>> On 8/19/2019 12:33 PM, Andy Herrick wrote:
>>>> Please review the jpackage fix for bug [1] at [2].
>>>>
>>>> This is a fix for the JDK-8200758-branch branch of the open sandbox 
>>>> repository (jpackage).
>>>>
>>>> [1] https://bugs.openjdk.java.net/browse/JDK-8229795
>>>>
>>>> [2] http://cr.openjdk.java.net/~herrick/8229795/
>>>>
>>>> /Andy
>>>>
>>>>
>>>
>



More information about the core-libs-dev mailing list