RFR: 8228581: Archive BigInteger constants

Brian Burkhalter brian.burkhalter at oracle.com
Fri Aug 23 18:26:21 UTC 2019


Hi Claes,

> On Aug 23, 2019, at 7:54 AM, Claes Redestad <claes.redestad at oracle.com> wrote:
> 
> On 2019-08-22 11:47, Alan Bateman wrote:
>> On 24/07/2019 14:28, Claes Redestad wrote:
>>> Webrev: http://cr.openjdk.java.net/~redestad/8228581/open.00/ <http://cr.openjdk.java.net/~redestad/8228581/open.00/>
>>> 
>> This looks good to me but I think it would be useful to have Joe or Brian or someone else more steeped in BigInteger to also scan the changes and recommend any additional testing.
>> -Alan
> 
> Thanks Alan,
> 
> however, I've chatted with Brian since this one conflicts with changes
> in JDK-8229845[1]: some of the optimizations there reduce the amount of
> objects created during initialization, which mean we won't profit as
> much from archiving, so I'll hold this back until JDK-8229845 is
> integrated, rebase and evaluate that this is still a worthwhile
> enhancement.

If it’s OK with you, I will hold off scanning the changes for this issue until [1] has been resolved one way or another.

Thanks,

Brian

[1] https://bugs.openjdk.java.net/browse/JDK-8229845


More information about the core-libs-dev mailing list