RFR: 8230043: Lazily load libverify

Alan Bateman Alan.Bateman at oracle.com
Sat Aug 24 08:00:50 UTC 2019


On 23/08/2019 14:08, Claes Redestad wrote:
> Hi,
>
> please review this cleanup to untangle the old bytecode verifier
> (libverify). It's currently linked and loaded eagerly and early during
> bootstrap.
>
> Webrev: http://cr.openjdk.java.net/~redestad/8230043/webrev.00/
> Bug:    https://bugs.openjdk.java.net/browse/JDK-8230043
>
This mostly looks good to me.

One thing that I'm wondering if whether the fixClassname usages could be 
replaced with verifyFixClassname as the former will abort the replace 
when a UTF-8 sequence can't be decoded. I think the comments (which 
pre-date your changes) also need to be re-examined as verifyFixClassname 
as it will return JNI_FALSE when the scan is aborted.

-Alan.




More information about the core-libs-dev mailing list