RFR (S) 8226831 : Use Objects.equals() when appropriate
Brian Burkhalter
brian.burkhalter at oracle.com
Tue Aug 27 20:12:59 UTC 2019
Hi Ivan,
+1
Brian
> On Aug 27, 2019, at 12:41 PM, Roger Riggs <Roger.Riggs at oracle.com> wrote:
>
> Hi Ivan,
>
> These look fine.
>
> Regards, Roger
>
>
> On 8/27/19 2:21 PM, Ivan Gerasimov wrote:
>> Hello!
>>
>> null-aware comparison of Objects is widely used, so it's tempting to use Objects.equals for that.
>>
>> Unfortunately, there are concerns w.r.t performance (see JDK-8015417), so it seems to better avoid this kind of refactoring in the performance critical code.
>>
>> Please find the webrev with a few places cleaned up (I had more, but decided to limit this patch due to the concern mentioned above).
>>
>> BUGURL: https://bugs.openjdk.java.net/browse/JDK-8226831
>> WEBREV: http://cr.openjdk.java.net/~igerasim/8226831/00/webrev/
>>
>> Thanks in advance!
>>
>
More information about the core-libs-dev
mailing list