RFR: JDK-8229979: jpackage cleanup src files, help text, and javadoc
Alexey Semenyuk
alexey.semenyuk at oracle.com
Wed Aug 28 16:45:02 UTC 2019
Understood. Thank you for explanation.
- Alexey
On 8/28/2019 12:43 PM, Andy Herrick wrote:
>
> On 8/28/2019 11:47 AM, Alexey Semenyuk wrote:
>> Looks good.
>>
>> Some files in the review contain no diffs though, like
>> http://cr.openjdk.java.net/~herrick/8229979/webrev.01/test/jdk/tools/jpackage/windows/exe/WinUpgradeUUIDTest.java.sdiff.html.
>> Why are they in the review?
>
> I ran a script to remove extraneous trailing spaces and fix file
> permission. The result is that the file changed, but webrev has
> nothing to show. I built the webrev with a file list so all changed
> files are these, even if there is no visible change.
>
> /ANdy
>
>>
>> - Alexey
>>
>> On 8/28/2019 9:36 AM, Andy Herrick wrote:
>>> Please review the jpackage fix for bug [1] at [2].
>>>
>>> This is a fix for the JDK-8200758-branch branch of the open sandbox
>>> repository (jpackage).
>>>
>>> [1] https://bugs.openjdk.java.net/browse/JDK-8229979
>>>
>>> [2] http://cr.openjdk.java.net/~herrick/8229979/
>>>
>>> Thanks,
>>> Andy
>>>
>>>
>>
More information about the core-libs-dev
mailing list