RFR [14/java.xml] 8230094: CCE in createXMLEventWriter(Result) over an arbitrary XMLStreamWriter

Joe Wang huizhe.wang at oracle.com
Wed Aug 28 19:04:34 UTC 2019


On 8/28/19 8:12 AM, Lance Andersen wrote:
> Hi Joe,
>
> The change and test look OK

Thanks Lance!
>
>> On Aug 27, 2019, at 1:20 PM, Joe Wang <huizhe.wang at oracle.com 
>> <mailto:huizhe.wang at oracle.com>> wrote:
>>
>> Please review a patch for an issue where a custom impl of 
>> XMLStreamWriter caused a CCE. The problem was that our implementation 
>> was changed to an internally extended interface. We could consider 
>> making it external, but for now, we'll do with a check.
>>
>> Note that there's no material change in XMLOutputFactoryImpl.java 
>> except a minor one at line 160.
>
> took a moment to spot the change here :-)

It's hidden in there ;-)

Best,
Joe

>
> Best
> Lance
>>
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8230094
>> webrev: http://cr.openjdk.java.net/~joehw/jdk14/8230094/webrev/
>>
>> Thanks,
>> Joe
>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif><http://oracle.com/us/design/oracle-email-sig-198324.gif>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance 
> Andersen| Principal Member of Technical Staff | +1.781.442.2037
> Oracle Java Engineering
> 1 Network Drive
> Burlington, MA 01803
> Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>
>
>
>



More information about the core-libs-dev mailing list