RFR: 8234964: failure_handler: gather more environment information on Windows, Solaris and Linux

[Vyom Tiwari]

Hi Julia,

changes looks good to me.
Thanks,
Vyom

On Mon, Dec 2, 2019 at 4:24 PM Julia Boes <julia.boes at oracle.com> wrote:

> Hi,
>
>
> > to make it more consistent w/ other tools, I'd move all ifconfig (incl.
> one on macOS) to 'net' category, i.e. rename them to net.ifconfig, this
> will require also moving all netstat.* on macOS and solaris to 'net' as
> well. I don't insist on it, though.
>
> Good point, I made those changes.
>
>
> > Changes looks OK to me although i have one question, in case of
> > Solaris you use explicit path to ifconfig(ifconfig.app=/sbin/ifconfig).
> > Does Solaris by default doesn't set the /sbin folder to user's 'PATH'
> > environment variable ?
>
> That's right, /sbin is not on the PATH on the Solaris machines of the
> test farm, which can be confirmed under the 'env' section of the
> environment information output.
>
>
> Updated webrev:
> http://cr.openjdk.java.net/~jboes/webrevs/8234964/webrev.01/
>
>
> Regards,
>
> Julia
>
>
>

-- 
Thanks,
Vyom