RFR JDK-8234049: Implementation of Memory Access API (Incubator)

[Maurizio Cimadamore]

Thanks for the extra testing!

Maurizio

On 10/12/2019 10:03, Andrew Dinn wrote:
> Hi Maurizio,
>
> It's nice to see this squeezing into jdk14.
>
> On 09/12/2019 19:23, Maurizio Cimadamore wrote:
>> Another iteration:
>>
>> http://cr.openjdk.java.net/~mcimadamore/panama/8234049_v4/
> I eyeballed all the changes to the Buffer classes and saw no issues.
> Also, apologies for the mixed brace/nobrace else-if cascade in
> FileChannelImpl.java spotted by Roger which was my fault -- I should
> really have introduced braces uniformly across the whole if/else-if/else
> sequence.
>
> Also, I reran pmem tests to verify that your buffer changes don't
> disrupt the behaviour of sync mapped byte buffers and all is well.
>
> regards,
>
>
> Andrew Dinn
> -----------
> Senior Principal Software Engineer
> Red Hat UK Ltd
> Registered in England and Wales under Company Registration No. 03798903
> Directors: Michael Cunningham, Michael ("Mike") O'Neill
>