8235668: LineNumberReader#getLineNumber() returns wrong line number (one fewer) in Lucene test

Roger Riggs Roger.Riggs at oracle.com
Thu Dec 12 15:46:23 UTC 2019


Hi Brian,

ok, the revert looks fine.

Roger


On 12/11/19 7:08 PM, Brian Burkhalter wrote:
> https://bugs.openjdk.java.net/browse/JDK-8235668
> http://cr.openjdk.java.net/~bpb/8235668/webrev.00/
>
> Due to the problems reported in [1], in the interest of not changing longstanding behavior, we would like to revert the fix for [2], despite the fact that it makes the behavior of LineNumberReader more consistent with its specification. An issue [3] was filed to revisit this situation in the future.
>
> The changes made to revert BufferedReader were done manually but the other two files were straight reversions to the previous delta. Note that the copyright date “2019” is removed from the test. Is that correct?
>
> Thanks,
>
> Brian
>
> [1] https://bugs.openjdk.java.net/browse/JDK-8235668
> [2] https://bugs.openjdk.java.net/browse/JDK-8230342
> [3] https://bugs.openjdk.java.net/browse/JDK-8235792



More information about the core-libs-dev mailing list