RFR: JDK-8235667: IOUtils.copyFile() problems.

[Roger Riggs]

Hi Andy,

The change looks ok.

(As long as the files being copied have the needed execute, write and 
read permissions.)

Roger


On 12/16/19 10:32 AM, Andy Herrick wrote:
> can I get a review from a Reviewer to push this simple fix in JDK-15 ?
>
> /Andy
>
>
> On 12/10/2019 3:00 PM, Andy Herrick wrote:
>>
>> On 12/10/2019 12:56 PM, Andy Herrick wrote:
>>> Please review the jpackage fix at [1] to issue [2].
>>>
>>> This is a change to jpackage/internal/IOUtils.copyFile() to 
>>> essentially replace it's content with a call to Files.copy()
>>>
>>> [1] http://cr.openjdk.java.net/~herrick/8235667/
>>>
>>> [2] https://bugs.openjdk.java.net/browse/JDK-8235667
>>>
>>> /Andy
>>>
>> given the suggestion:
>>> The method ignores the return from mkdirs, you could replace that 
>>> with Files.createDirectories if you want the IOException. 
>>
>> I have revised the webrev at [3]
>>
>> [3] http://cr.openjdk.java.net/~herrick/8235667/webrev.02/
>>
>> /Andy
>>