RFR 8218195: [testlibrary] Diagnostic output for test library ProcessTools

Roger Riggs Roger.Riggs at oracle.com
Fri Feb 1 17:48:01 UTC 2019


Hi Igor,

ok, no need to add useless code.

And yes there might be timing issue;  but the output is purely 
diagnostic and
it does not throw an exception so by itself would not cause the test to 
misbehave.

Roger


On 02/01/2019 12:19 PM, Igor Ignatyev wrote:
> Hi Roger,
>
> it looks like we might get false-positive "Process terminated unexpectedly" w/ this patch and as JDK-8218197 seems to better explain the evidence, I don't think we need this patch at all.
>
> Thanks,
> -- Igor
>
>> On Feb 1, 2019, at 8:47 AM, Roger Riggs <Roger.Riggs at Oracle.com> wrote:
>>
>> Please review the addition of diagnostic output to the test library ProcessTools.executeProcess
>> to aid in diagnosing several unexplained timeouts.
>>
>> It adds a second check for process being aliev using ProcessHandle and prints
>> information about the current process and its descendents and all processes.
>>
>> Webrev:
>>     http://cr.openjdk.java.net/~rriggs/webrev-pt-alive-patch-1/
>>
>> Thanks, Roger
>>



More information about the core-libs-dev mailing list