[PATCH] Improvements in jdk.internal.org.objectweb.asm.Type

Alan Bateman Alan.Bateman at oracle.com
Thu Feb 7 08:42:09 UTC 2019


On 06/02/2019 21:26, Сергей Цыпанов wrote:
> Hello,
>
> several days ago I’ve proposed some improvements into asm library:
>
> - https://gitlab.ow2.org/asm/asm/commit/ef945457bc19dbc09c02bd21b52f1950990f33f7
> - https://gitlab.ow2.org/asm/asm/commit/9b914d524b7fe7ea694fc11ec784e67133ba383f
>
>
> The patches were accepted and then it turned out the code I’ve patched is similar to what we have in JDK.
>
> So I propose the same changes to be accepted into JDK 12. They improve code by using more simple constructions and replacing redundant hand-written code with JDK-provided API.
I assume the JDK will get your performance fix at the next ASM refresh. 
We've tried to avoid changes to ASM where possible as it complicates 
upgrading. There are of course times when the JDK's copy of ASM is 
modified to support changes to the class file before they are finalized 
and in a ASM release but we usually don't apply other patches unless 
they are really needed.

-Alan


More information about the core-libs-dev mailing list