RFR: JDK-8214564 : --win-upgrade-uuid does not work as expected

Andy Herrick andy.herrick at oracle.com
Thu Feb 7 17:12:09 UTC 2019


looks good to me.

/ANdy


On 2/6/2019 11:18 PM, Alexander Matveev wrote:
> Please review the jpackage fix for bug [1] at [2].
>
> This is a fix for the JDK-8200758-branch branch of the open sandbox 
> repository (jpackage).
>
> - Upgrade did not work, because <MajorUpgrade> element was missing. 
> Fixed by adding this element if --win-upgrade-uuid was provided.
> - Minor code clean up. Removed JPackageCreateImageBuildRootTest.java.rej.
> - Added JPackageCreateInstallerWinUpgradeUUIDTest for msi and exe. 
> Note: For exe files which are not present in newer installation will 
> not be removed. This is default behavior of InnoSetup installations. 
> For msi older version will be completely removed before new one is 
> installed. We will allow downgrades, upgrades and same version 
> re-install for both msi and exe.
>
> [1] https://bugs.openjdk.java.net/browse/JDK-8214564
>
> [2] http://cr.openjdk.java.net/~almatvee/8214564/webrev.00/
>
> Thanks,
> Alexander



More information about the core-libs-dev mailing list