RFR: JDK-8217687: jpackage --help improvements
Andy Herrick
andy.herrick at oracle.com
Fri Feb 8 13:28:30 UTC 2019
On 2/7/2019 5:11 PM, Alexander Matveev wrote:
> Hi Andy,
>
> http://cr.openjdk.java.net/~herrick/8217687/webrev.01/src/jdk.jpackage/share/classes/jdk/jpackage/internal/resources/MainResources.properties.frames.html
>
> Line 140: I think we do not need " at the end.
yes - will remove this before push
/Andy
>
> Otherwise looks fine.
>
> Thanks,
> Alexander
>
> On 2/7/2019 9:11 AM, Andy Herrick wrote:
>> Please review the jpackage fix for bug [1] at [2].
>>
>> This is a fix for the JDK-8200758-branch branch of the open sandbox
>> repository (jpackage).
>>
>> JDK-8217687: jpackage --help improvements
>>
>> Changes to help text, internal names, and several tests.
>>
>> [1] https://bugs.openjdk.java.net/browse/JDK-8217687
>>
>> [2] http://cr.openjdk.java.net/~herrick/8217687/webrev.01/
>>
>>
>>
>
More information about the core-libs-dev
mailing list