Faulty Null-Check Suspected in ToolProvider

[Jonathan Gibbons]

On 2/16/19 12:20 AM, Philipp Kunz wrote:
> I'm also wondering about the call to flush in run(PrintStream out,
> PrintStream err, String... args). It looks like the intention was to
> flush the wrapping PrintWriter.
> That is not possible without also flushing the underlying PrintStream.
> BufferedWriter.flushBuffer would be a more sensible method to call but
> is not accessible.
> The effect is actually, that the call to PrintWriter.flush will also
> call flush of the underlying PrintStream. Should that be documented
> more explicitly, for example:

Philipp,

I don't see that it needs to be specified.

It is a reasonable presumption that everything written by the tool
is propagated to the streams passed into the run method. How that
is achieved is an implementation detail.

If you were to modify the spec, it would at most be an implementation
detail, and should appear in an @implNote.

-- Jon