RFR: JDK11U JDK-8206120, JDK-8211398, JDK-8218915

[Seán Coffey]

Deepak,

changes look fine to me. Some minor comments on formatting :

make a space after all  "//" comments

e.g.
+         //isJavaIdentifierStart strictly conforms to code points assigned
+         //in Unicode 10.0. Since code point {32FF} is not from Unicode 
10.0,
+         //return false.

   33     //New code point(Japanese Era Square character) not present in 
Unicode 10.0
   34     private static final int newCodePoint = 0x32FF;

   65             //Since Character.isJavaIdentifierPart(int) strictly 
conforms to
   66             //character information from version 10.0 of the 
Unicode Standard,
   67             //check if code point is new code point. If the code 
point is new
   68             //code point, value of variable expected is considered 
false.


   typo in comment :
   make/data/characterdata/CharacterData00.java.template

         boolean isJavaIdentifierPart(int ch) {
+         //isJavaIdentifierStart strictly conforms to code points assigned
+         //in Unicode 10.0. Since code point {32FF} is not from Unicode 
10.0,

regards,
Sean.

On 19/02/2019 14:15, Deepak Kejriwal wrote:
> Correcting typo for release.
>
>   
>
> From: Deepak Kejriwal <deepak.kejriwal at oracle.com>
> Sent: Tuesday, February 19, 2019 7:42 PM
> To: 'core-libs-dev' <core-libs-dev at openjdk.java.net>; 'jdk-updates-dev at openjdk.java.net' <jdk-updates-dev at openjdk.java.net>
> Subject: RFR: JDK11U JDK-8206120, JDK-8211398, JDK-8218915
>
>   
>
> Hi All,
>
> Please review the backport of the following bug fixes to jdk11u-dev:
>
> HYPERLINK "https://bugs.openjdk.java.net/browse/JDK-8206120"JDK-8206120 : Add test cases for lenient Japanese era parsing
> HYPERLINK "https://bugs.openjdk.java.net/browse/JDK-8211398"JDK-8211398 : Square character support for the Japanese new era
> HYPERLINK "https://bugs.openjdk.java.net/browse/JDK-8218915"JDK-8218915 : Change isJavaIdentifierStart and isJavaIdentifierPart to handle new code points
>
> Webrev:  http://cr.openjdk.java.net/~rpatil/JapaneseEra_changes_11u/webrev.00/
>
> These code changes are made possible thanks to specification change already pushed:
> http://hg.openjdk.java.net/jdk-updates/jdk11u/rev/c1e1669edace
>
> Regards,
> Deepak
>
>