RFR: JDK8U JDK-8202088, JDK-8207152, JDK-8211398, JDK-8180469, JDK-8206120, JDK-8218915, JDK-8217710

[Seán Coffey]

Looks fine to me.

some minor comments on formatting :

space after "//" style comments in your new tests :

e.g

> //List of new code points are not present in Unicode 6.2.
>    39                                          add(0x20BB); //NORDIC MARK SIGN
>    40                                          add(0x20BC); //MANAT SIGN
>    41                                          add(0x20BD); //RUBLE SIGN
>    42                                          add(0x20BE); //LARI SIGN
>    43                                          add(0x20BF); //BITCOIN SIGN
>    44                                          add(0x32FF); //SQUARE ERA NAME NEWERA

>    77             //Since Character.isJavaIdentifierPart(int) strictly conforms to
>    78             //character information from version 6.2 of the Unicode Standard,
>    79             //check if code point is new code point. If the code point is new
>    80             //code point, value of variable expected is considered false.
this looks like a typo in one of your new tests :

>   268     public static void testIsJavaLetterOrDigit() {
>   269         for (int i = 0; i <= Character.MAX_VALUE; ++i) {
>   270             char ch = (char) i;
>   271             boolean expected = false;
>   272             //Since Character.isIdentifierIgnorable(char) strictly conforms to
regards,
Sean.

On 19/02/2019 13:55, Deepak Kejriwal wrote:
> Hi All,
>
> Please review the backport of the following bug fixes to jdk8u-dev:
>
> HYPERLINK "https://bugs.openjdk.java.net/browse/JDK-8202088"JDK-8202088: Japanese new era implementation.
> HYPERLINK "https://bugs.openjdk.java.net/browse/JDK-8207152"JDK-8207152: Placeholder for Japanese new era should be two characters.
> HYPERLINK "https://bugs.openjdk.java.net/browse/JDK-8211398"JDK-8211398 : Square character support for the Japanese new era
> HYPERLINK "https://bugs.openjdk.java.net/browse/JDK-8180469"JDK-8180469 : Wrong short form text for supplemental Japanese era
> HYPERLINK "https://bugs.openjdk.java.net/browse/JDK-8206120"JDK-8206120 : Add test cases for lenient Japanese era parsing
> HYPERLINK "https://bugs.openjdk.java.net/browse/JDK-8218915"JDK-8218915 : Change isJavaIdentifierStart and isJavaIdentifierPart to handle new code points
> HYPERLINK "https://bugs.openjdk.java.net/browse/JDK-8217710"JDK-8217710 : Add 5 currency code points to Java SE 8uX
>
> Webrev:  http://cr.openjdk.java.net/~rpatil/JapaneseEra_and_Currency_changes_8u/webrev.00/
>
> These code changes are made possible thanks to specification changes already pushed:
> http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/c35f231af17a
> http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/00475cd329f7
>
> Regards,
> Deepak
>
>   
>
>   
>
>