Fix proposal: JDK-8219378 NPE in ReflectionFactory.newMethodAccessor when langReflectAccess not initialized

[Roger Riggs]

Hi Andrew,

Thanks for the references and consideration.  I agree it will be hard to 
reproduce.
It is an obvious oversight and is localized to a single file so I don't 
think a test case is necessary.

Thanks, Roger


On 02/22/2019 03:49 AM, Andrew Leonard wrote:
> Hi Roger,
> I had a think about this and a testcase will be difficult, as it was 
> found during OpenJ9 testing and occured during VM bootstrap, feel free 
> to read
> further details here: 
> https://github.com/eclipse/openj9/issues/3399#issuecomment-459004840
> So the issue was discovered due to the bootstrap behaviour, it was not 
> observed with Hotspot, however given the obvious missing 
> initialization check logic in the class it's not to say there's an 
> untested route with Hotspot that could hit it... I'm not sure how I 
> could scaffold a jtreg test to replicate the same?
> Thanks
> Andrew
>
> Andrew Leonard
> Java Runtimes Development
> IBM Hursley
> IBM United Kingdom Ltd
> Phone internal: 245913, external: 01962 815913
> internet email: andrew_m_leonard at uk.ibm.com
>
>
>
>
> From: Roger Riggs <Roger.Riggs at oracle.com>
> To: core-libs-dev at openjdk.java.net, Andrew Leonard 
> <andrew_m_leonard at uk.ibm.com>
> Date: 21/02/2019 18:10
> Subject: Re: Fix proposal: JDK-8219378 NPE in 
> ReflectionFactory.newMethodAccessor when langReflectAccess not 
> initialized
> ------------------------------------------------------------------------
>
>
>
> Hi Andrew,
>
> Is there a test case?  Since the initialization is a side effect of 
> static initialization,
> it might be hard to trigger just one of those paths.  How was it 
> discovered?
>
> Thanks, Roger
>
>
> On 02/21/2019 11:57 AM, Alan Bateman wrote:
> On 21/02/2019 16:49, Roger Riggs wrote:
> Hi Andrew,
>
> I can sponsor; it looks correct to me.
>
> Any other reviewers?
> It looks right but would be good to have a test case that demonstrates 
> the issue.
>
> -Alan
>
>
>
> Unless stated otherwise above:
> IBM United Kingdom Limited - Registered in England and Wales with 
> number 741598.
> Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU