RFR: JDK-8219480: j.l.c.ClassDesc::arrayType(int rank) throws IllegalArgumentException if rank = 0

Vicente Romero vicente.romero at oracle.com
Fri Feb 22 16:37:55 UTC 2019


Hi Mandy,

Thanks for the review. I have uploaded a new iteration [1], please also 
review the CSR at [2]

Vicente

[1] http://cr.openjdk.java.net/~vromero/8219480/webrev.01/
[2] https://bugs.openjdk.java.net/browse/JDK-8219587


On 2/21/19 5:22 PM, Mandy Chung wrote:
>
>
> On 2/20/19 3:10 PM, Vicente Romero wrote:
>> Please review the simple patch to fix [1] at [2]. The patch is simply 
>> adding a comment to the API, (javadoc) to sync it with the 
>> implementation.
>>
>> Thanks,
>> Vicente
>>
>> [1] https://bugs.openjdk.java.net/browse/JDK-8219480
>> [2] http://cr.openjdk.java.net/~vromero/8219480/webrev.00/
>
> +     * @throws IllegalArgumentException if the rank is less or equal 
> to zero or if the rank of the resulting array type is
>
> typo: s/less or equal to/less than or equal to/
>
> This needs a CSR for the spec fix.
>
> Mandy



More information about the core-libs-dev mailing list