RFR: 8219548 Re: Faulty Null-Check Suspected in ToolProvider

[Jonathan Gibbons]

Looks good to me.

-- Jon

On 2/21/19 12:34 PM, Lance Andersen wrote:
> Here is the webrev of the patch from Philipp.  I did not change the name of the test() method as it was not necessary
>
> http://cr.openjdk.java.net/~lancea/8219548/webrev.00/
>
>
>> On Feb 15, 2019, at 6:59 PM, Philipp Kunz <philipp.kunz at paratix.ch> wrote:
>>
>> Hi Lance,
>>
>> See attached patch.
>>
>> Regards,
>> Philipp
>>
>>
>> On Fri, 2019-02-15 at 18:10 -0500, Lance Andersen wrote:
>>> Hi Philipp
>>>
>>> This probably makes sense to update.
>>>
>>> Can you also update the ToolProviderTest.java to add a test for the changes
>>>
>>> Thank you
>>>
>>> Best
>>> Lance
>>>
>>>> On Feb 15, 2019, at 4:43 PM, Philipp Kunz <philipp.kunz at paratix.ch <mailto:philipp.kunz at paratix.ch>> wrote:
>>>>
>>>> <ToolProviderNullCheck.patch>
>>> <oracle_sig_logo.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>>>   <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>>>   <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
>>> Oracle Java Engineering
>>> 1 Network Drive
>>> Burlington, MA 01803
>>> Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>
>>>
>>>
>>>
>> <ToolProviderNullCheck.patch>
>   <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>   <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>   <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
> Oracle Java Engineering
> 1 Network Drive
> Burlington, MA 01803
> Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>
>
>
>