RFR: JDK-8218681 : Windows exe's generated by jpackage have wrong info

[Andy Herrick]

This looks good

/Andy


On 2/22/2019 5:26 PM, Alexander Matveev wrote:
> Please review the jpackage fix for bug [1] at [2].
>
> This is a fix for the JDK-8200758-branch branch of the open sandbox 
> repository (jpackage).
>
> - User provided version was not display, because it was added as 
> additional LANG_ENGLISH resource and Windows Explorer was displaying 
> default one added during build as LANG_NEUTRAL. Fixed by 
> adding/modifying version information as LANG_NEUTRAL resource.
> - Removed unused fields from WinLauncher.template.
> - Improved error handling for version swap.
> - Fixed debug build after JDK-8212091 by removing not needed code from 
> #ifdef DEBUG.
>
> [1] https://bugs.openjdk.java.net/browse/JDK-8218681
>
> [2] http://cr.openjdk.java.net/~almatvee/8218681/webrev.00/
>
> Thanks,
> Alexander