RFR: 8182992 Typo in DatagramPacket constructor API doc

Roger Calnan roger.calnan at oracle.com
Fri Jan 4 17:41:59 UTC 2019


>> -     * suitable for retrieving large{@code LONGVARCHAR}values.  The JDBC driver will
>> +     * suitable for retrieving large{@code LONGVARCHAR} values.  The JDBC driver will
> Needs a space after large

	indeed, I looked for other examples and found a couple more.  I’ll file a bug to get them fixed,

	Thanks,

	Roger

> From: Lance Andersen <lance.andersen at oracle.com>
> Subject: Re: RFR: 8182992 Typo in DatagramPacket constructor API doc
> Date: January 3, 2019 at 9:53:07 AM PST
> To: Roger Calnan <roger.calnan at oracle.com>
> Cc: core-libs-dev at openjdk.java.net
> 
> 
> Hi Roger,
> 
> Please see below.  I am not sure how much review the javadocs have gotten  for the com/sun/rowset/internal classes
> 
> 
>> 
>> 
>> 
>> JDK-8215911 Various Typos in SQL Method Documentation
>> https://bugs.openjdk.java.net/browse/JDK-8215911 <https://bugs.openjdk.java.net/browse/JDK-8215911> <https://bugs.openjdk.java.net/browse/JDK-8215911 <https://bugs.openjdk.java.net/browse/JDK-8215911>>https://hg.openjdk.java.net/jdk/jdk/file/abe21b82ff7c/src/java.sql.rowset/share/classes/com/sun/rowset/internal/SyncResolverImpl.java#l1067 <https://hg.openjdk.java.net/jdk/jdk/file/abe21b82ff7c/src/java.sql.rowset/share/classes/com/sun/rowset/internal/SyncResolverImpl.java#l1067> <https://hg.openjdk.java.net/jdk/jdk/file/abe21b82ff7c/src/java.sql.rowset/share/classes/com/sun/rowset/internal/SyncResolverImpl.java#l1067 <https://hg.openjdk.java.net/jdk/jdk/file/abe21b82ff7c/src/java.sql.rowset/share/classes/com/sun/rowset/internal/SyncResolverImpl.java#l1067>>
>> 
>> diff -r 3d0f6ef91216 src/java.sql.rowset/share/classes/com/sun/rowset/internal/SyncResolverImpl.java
>> --- a/src/java.sql.rowset/share/classes/com/sun/rowset/internal/SyncResolverImpl.java	Wed Jan 02 13:37:55 2019 -0500
>> +++ b/src/java.sql.rowset/share/classes/com/sun/rowset/internal/SyncResolverImpl.java	Wed Jan 02 13:19:38 2019 -0800
>> @@ -1,5 +1,5 @@
>> /*
>> - * Copyright (c) 2004, 2013, Oracle and/or its affiliates. All rights reserved.
>> + * Copyright (c) 2004, 2019, Oracle and/or its affiliates. All rights reserved.
>>  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
>>  *
>>  * This code is free software; you can redistribute it and/or modify it
>> @@ -1064,7 +1064,7 @@
>> 
>>     /**
>>      * Returns the insert row or the current row of this
>> -     * {@code CachedRowSetImpl}object.
>> +     * {@code CachedRowSetImpl} object.
>>      *
>>      * @return the {@code Row} object on which this {@code CachedRowSetImpl}
>>      * objects's cursor is positioned
>> @@ -4326,7 +4326,7 @@
>>      *
>>      * @param columnName a {@code String} object that must match the
>>      *        SQL name of a column in this rowset, ignoring case
>> -     * @param c the new column {@code Clob}value
>> +     * @param c the new column {@code Clob} value
>>      * @throws SQLException if (1) the given column name does not match the
>>      *            name of a column in this rowset, (2) the cursor is not on
>>      *            one of this rowset's rows or its insert row, or (3) this
>> 
>> https://hg.openjdk.java.net/jdk/jdk/file/abe21b82ff7c/src/java.sql.rowset/share/classes/com/sun/rowset/JdbcRowSetImpl.java#l1136 <https://hg.openjdk.java.net/jdk/jdk/file/abe21b82ff7c/src/java.sql.rowset/share/classes/com/sun/rowset/JdbcRowSetImpl.java#l1136> <https://hg.openjdk.java.net/jdk/jdk/file/abe21b82ff7c/src/java.sql.rowset/share/classes/com/sun/rowset/JdbcRowSetImpl.java#l1136 <https://hg.openjdk.java.net/jdk/jdk/file/abe21b82ff7c/src/java.sql.rowset/share/classes/com/sun/rowset/JdbcRowSetImpl.java#l1136>>
>> https://hg.openjdk.java.net/jdk/jdk/file/abe21b82ff7c/src/java.sql.rowset/share/classes/com/sun/rowset/JdbcRowSetImpl.java#l6191 <https://hg.openjdk.java.net/jdk/jdk/file/abe21b82ff7c/src/java.sql.rowset/share/classes/com/sun/rowset/JdbcRowSetImpl.java#l6191> <https://hg.openjdk.java.net/jdk/jdk/file/abe21b82ff7c/src/java.sql.rowset/share/classes/com/sun/rowset/JdbcRowSetImpl.java#l6191 <https://hg.openjdk.java.net/jdk/jdk/file/abe21b82ff7c/src/java.sql.rowset/share/classes/com/sun/rowset/JdbcRowSetImpl.java#l6191>>
>> 
>> diff -r abe21b82ff7c src/java.sql.rowset/share/classes/com/sun/rowset/JdbcRowSetImpl.java
>> diff -r 3d0f6ef91216 src/java.sql.rowset/share/classes/com/sun/rowset/JdbcRowSetImpl.java
>> --- a/src/java.sql.rowset/share/classes/com/sun/rowset/JdbcRowSetImpl.java	Wed Jan 02 13:37:55 2019 -0500
>> +++ b/src/java.sql.rowset/share/classes/com/sun/rowset/JdbcRowSetImpl.java	Wed Jan 02 13:19:38 2019 -0800
>> @@ -1,5 +1,5 @@
>> /*
>> - * Copyright (c) 2003, 2013, Oracle and/or its affiliates. All rights reserved.
>> + * Copyright (c) 2003, 2019, Oracle and/or its affiliates. All rights reserved.
>>  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
>>  *
>>  * This code is free software; you can redistribute it and/or modify it
>> @@ -1133,7 +1133,7 @@
>>      * as a stream of Unicode characters.
>>      * The value can then be read in chunks from the
>>      * stream. This method is particularly
>> -     * suitable for retrieving large{@code LONGVARCHAR}values.  The JDBC driver will
>> +     * suitable for retrieving large{@code LONGVARCHAR} values.  The JDBC driver will
> Needs a space after large
>>      * do any necessary conversion from the database format into Unicode.
>>      * The byte format of the Unicode stream must be Java UTF-8,
>>      * as specified in the Java virtual machine specification.
>> @@ -6188,7 +6188,7 @@
>>    * @param parameterIndex index of the first parameter is 1, the second is 2, ...
>>    * @param reader An object that contains the data to set the parameter value to.
>>    * @throws SQLException if a database access error occurs, this method is called on
>> -   *         a closed {@code PreparedStatement}or if parameterIndex does not correspond to a parameter
>> +   *         a closed {@code PreparedStatement} or if parameterIndex does not correspond to a parameter
>>    *         marker in the SQL statement
>>    *
>>    * @throws SQLFeatureNotSupportedException  if the JDBC driver does not support this method
>> 
>> 
> 
> looks fine otherwise
> 
>  <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>  <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>  <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
> Oracle Java Engineering 
> 1 Network Drive 
> Burlington, MA 01803
> Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>
> 
> 
> 


More information about the core-libs-dev mailing list