RFR 8211919: ZipDirectoryStream should provide a stream of paths that are relative to the directory

Lance Andersen lance.andersen at oracle.com
Tue Jan 15 00:13:18 UTC 2019


> On Jan 14, 2019, at 2:05 PM, Alan Bateman <Alan.Bateman at oracle.com> wrote:
> 
> On 12/01/2019 20:13, Lance Andersen wrote:
>> Hi all,
>> 
>> The following patch addresses the issue where the stream of paths where not relative to the specified directory as needed.
>> 
>> As part of the fix, I added additional DirectoryStream tests similar to the tests in nio/file/DirectoryStream/Basic.java.
>> 
>> Webrev can be found: http://cr.openjdk.java.net/~lancea/8211919/webrev.00/
>> 
> Lance -the relative path case looks right now but I think there are issues with the absolute path case. Try an example such as "/META-INF/../META-INF" to see what I mean.

Thank you Alan pointing out this example which the previous fix also did not address.  I updated the change which addresses the above example as well as the relative path

Please see http://cr.openjdk.java.net/~lancea/8211919/webrev.02/index.html

Best
Lance
> 
> -Alan

 <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>





More information about the core-libs-dev mailing list