[13] RFR: 8216969: ParseException thrown for certain months with russian locale

Nishit Jain nishit.jain at oracle.com
Fri Jan 18 09:57:14 UTC 2019


Looks Good.

Regards,
Nishit Jain
On 17-01-2019 22:07, Naoto Sato wrote:
> Hi Nishit,
>
> Thanks. Updated:
>
> http://cr.openjdk.java.net/~naoto/8216969/webrev.01/
>
> Naoto
>
> On 1/17/19 2:57 AM, Nishit Jain wrote:
>> Hi Naoto,
>>
>> Looks good to me. Just a small suggestion.
>>
>> - To improve readability, can we declare "standalone mask" (0x8000) 
>> as a static field and use that at all the places?
>>
>> Regards,
>> Nishit Jain
>> On 17-01-2019 05:50, naoto.sato at oracle.com wrote:
>>> Hi,
>>>
>>> Please review the fix to the following issue:
>>>
>>> https://bugs.openjdk.java.net/browse/JDK-8216969
>>>
>>> The proposed changeset is located at:
>>>
>>> http://cr.openjdk.java.net/~naoto/8216969/webrev.00/
>>>
>>> For parsing the context sensitive month 'M', the logic was to look 
>>> for the best match for the short name regardless of the styles. 
>>> Changed the parsing code to take the context into account.
>>>
>>> Naoto
>>



More information about the core-libs-dev mailing list