RFR: JDK-8217393 Re: Clarification in Attributes equal

[Alan Bateman]

On 19/01/2019 12:46, Lance Andersen wrote:
> Hi all,
>
> Please review the  fix for JDK-8217393 which updates the javadocs for Attriibutes::equals to clarify its behavior to match its implementation
>
> —————
> hg diff
> diff -r c5d6b4480c6c src/java.base/share/classes/java/util/jar/Attributes.java
> --- a/src/java.base/share/classes/java/util/jar/Attributes.java	Thu Jan 17 13:46:12 2019 -0800
> +++ b/src/java.base/share/classes/java/util/jar/Attributes.java	Sat Jan 19 07:35:55 2019 -0500
> @@ -265,9 +265,10 @@
>       }
>   
>       /**
> -     * Compares the specified Attributes object with this Map for equality.
> -     * Returns true if the given object is also an instance of Attributes
> -     * and the two Attributes objects represent the same mappings.
> +     * Compares the specified object with this Map for equality.
> +     * Returns true if the given object is also a Map
> +     * and the two objects represent the same Manifest
> +     * attribute name-value mappings.
>
I think this looks okay although I like Martin's suggestion to just 
inherit the javadoc as Attributes is a Map.

-Alan