8215976: OpenJDK fails to build with GCC when the #include<time.h> inside zip.cpp comes from a non-sysroot path

[Patrick Zhang]

Appreciate all your kind help in making it happen.

Regards
Patrick

From: Roger Riggs <Roger.Riggs at oracle.com>
Sent: Tuesday, January 22, 2019 10:56 PM
To: David Holmes <david.holmes at oracle.com>; Patrick Zhang <patrick at os.amperecomputing.com>
Cc: core-libs-dev <core-libs-dev at openjdk.java.net>
Subject: Re: 8215976: OpenJDK fails to build with GCC when the #include<time.h> inside zip.cpp comes from a non-sysroot path

Hi David,

Thanks for running the tests.

Pushed.

Thanks, Roger
On 01/22/2019 01:45 AM, David Holmes wrote:
Mach 5 tier 1 - 3 tests passed on Linux/OS X/Windows x64 and Solaris sparcv9.

David

On 22/01/2019 2:01 pm, David Holmes wrote:

Hi Patrick,

I'm putting this through our test system (again) and will report back when its complete.

I also updated the bug report with the patch and assigned to Roger as the sponsor.

Cheers,
David

On 22/01/2019 12:21 pm, Patrick Zhang wrote:

Thanks Roger.

I did a try to push the patch within a branch to jdk/submit, and saw “Permission denied (publickey)”. I sent my SSH pub key to keys(at)openjdk.java.net but got no response. I heard only committers can have the access right, could you please help?

Regards

Patrick

*From:* Roger Riggs <Roger.Riggs at oracle.com><mailto:Roger.Riggs at oracle.com>
*Sent:* Wednesday, January 16, 2019 11:07 PM
*To:* Alan Bateman <Alan.Bateman at oracle.com><mailto:Alan.Bateman at oracle.com>; Patrick Zhang <patrick at os.amperecomputing.com><mailto:patrick at os.amperecomputing.com>; David Holmes <david.holmes at oracle.com><mailto:david.holmes at oracle.com>
*Cc:* core-libs-dev <core-libs-dev at openjdk.java.net><mailto:core-libs-dev at openjdk.java.net>
*Subject:* Re: 8215976: OpenJDK fails to build with GCC when the #include<time.h> inside zip.cpp comes from a non-sysroot path

Hi,

I can sponsor this. Let me know when the jdk-submit is complete.

Thanks, Roger

On 01/16/2019 10:03 AM, Alan Bateman wrote:

    On 16/01/2019 02:30, Patrick Zhang wrote:

        Looks .patch didn't work as an attachment, retry with .txt and
        paste the text below as well. Sorry for one more message here.

    I think this patch looks okay and I assume you'll test it in the
    jdk-submit repo to make sure it builds on all platforms.

    -Alan