RFR: JKDK-8217331, JDK-8217792

[Andy Herrick]

On 1/29/2019 5:11 PM, Alexander Matveev wrote:
> Hi Andy,
>
> http://cr.openjdk.java.net/~herrick/8217792/webrev.01/src/jdk.jpackage/share/classes/jdk/jpackage/internal/JLinkBundlerHelper.java.frames.html 
>
> Line 419 - Log.info() logs always. I think it is better to use 
> Log.verbose() or just remove it.
>
Actually, I had created a webrev.02 - but failed to post it - this 
section will be removed, including the Log statement.
There was some other feedback on this topic (what modules to include in 
a jre image) that I need to process - and may wind up with a different 
approach, so consider this RFR on hold till sometime tomorrow.
/Andy

> Otherwise looks good.
>
> Thanks,
> Alexander
>
>
> On 1/29/2019 12:57 PM, Andy Herrick wrote:
>> Please review the jpackage fix for bugs [1] and [2] at [3].
>>
>> These two fixes are for the JDK-8200758-branch branch of the open 
>> sandbox repository (jpackage).
>>
>> JDK-8217793 addresses what modules are included in the runtime of an 
>> application or jre image
>>
>> JDK-8217792 fixes the use of modular jars
>>
>> [1] https://bugs.openjdk.java.net/browse/JDK-8217793
>>
>> [2] https://bugs.openjdk.java.net/browse/JDK-8217792
>>
>> [3] http://cr.openjdk.java.net/~herrick/8217792/webrev.01/
>>
>> /Andy
>>
>