[12] RFR: 8216546: Support new Japanese era in java.lang.Character for Java SE 11

Chris Hegarty chris.hegarty at oracle.com
Thu Jan 31 09:15:32 UTC 2019


Naoto,

> On 31 Jan 2019, at 00:35, naoto.sato at oracle.com wrote:
> 
> ...
> 
> https://bugs.openjdk.java.net/browse/JDK-8217938
> http://cr.openjdk.java.net/~naoto/8216546/webrev.00/

This looks good. Just a few very minor comments.

1) To be consistent can you please include the addition of the
  word ‘conditions’ to the following methods:

    “... the following *conditions* is true:"

     isJavaIdentifierPart(char ch)
     isJavaIdentifierPart(int codePoint) 
     isJavaLetter(char ch) 
     isJavaIdentifierPart(char)

2)  There was a small correction in isJavaIdentifierPart(int). 

    Replace    "the character"  with   "the code point"

Thanks,
-Chris.



More information about the core-libs-dev mailing list