Review Request: JDK-8173978: Lookup.in should allow teleporting from a lookup class in a named module without dropping all access

Alan Bateman Alan.Bateman at oracle.com
Tue Jul 2 17:39:05 UTC 2019


On 02/07/2019 18:20, Mandy Chung wrote:
> :
>
>> I've taken several passes over the changes and I don't see anything 
>> obviously wrong. One minor nit is that the @throws 
>> IllegalAccessException in accessClass(Class) needs to be updated to 
>> allow for it to thrown when not accessible from the previous lookup 
>> class. Also VerifyAccess::isModuleAccessible shouldn't need to if the 
>> package is exported unconditionally as it is covered by 
>> isExported(pn, m1) && isExported(pn, m2).
>
> Good point.  Fixed.
>
> Webrev updated:
>    http://cr.openjdk.java.net/~mchung/jdk14/8173978/webrev.01/
>
The updated @throws IAE in accessClass and the updated 
VerifyAccess::isModuleAccessible looks good.

-Alan.



More information about the core-libs-dev mailing list