RFR [14/java.xml] 7148925: StAXSource causes exceptions to be thrown with certain wellformed XML instances

[Joe Wang]

On 7/9/19 3:07 PM, Lance Andersen wrote:
> Hi Joe,
>
> Overall, this looks good.

Thanks Lance!
>
> Please add the bug number to the top @bug in the test class.

Added.
>
>
> I might have defined all of the elements in the DataProvider “xml” in 
> separate String objects to make it easier to read, but no big deal and 
> does not need changed prior to pushing.

Thanks. I'm going to keep them this way then ;-)  They are small enough.

-Joe
>
>
>
>
>> On Jul 9, 2019, at 5:17 PM, Joe Wang <huizhe.wang at oracle.com 
>> <mailto:huizhe.wang at oracle.com>> wrote:
>>
>> Please review a fix for an Exception caused by StAXSource. The fix 
>> adds code that processes the prolog and misc content as specified by 
>> the XML specification, and removes the code that made incorrect 
>> assumption about XML document structure.
>>
>> https://bugs.openjdk.java.net/browse/JDK-7148925
>> http://cr.openjdk.java.net/~joehw/jdk14/7148925/webrev/
>>
>> Thanks,
>> Joe
>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif><http://oracle.com/us/design/oracle-email-sig-198324.gif>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance 
> Andersen| Principal Member of Technical Staff | +1.781.442.2037
> Oracle Java Engineering
> 1 Network Drive
> Burlington, MA 01803
> Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>
>
>
>