8131664: Javadoc for PrintStream is now incorrect

Lance Andersen lance.andersen at oracle.com
Mon Jul 15 20:33:04 UTC 2019


Hi Brian,

Is there an existing CSR or are you waiting for the review to complete here?

Overall, I think it is OK.

The existing autoflush wording looks  like it could use some wordsmithing at some point (as I know we do this a little differently in some of the APIs )

- “A boolean”  not sure we need to state this as it is obvious from the declaration.
-  Some places in the JDK, we say  True if XXXX; false otherwise.  I am not sure how many APIs after the really early ones  start  with “if true…”

Anyways, something to consider for a future todo list I guess :-) 

Best
Lance
> On Jul 15, 2019, at 4:03 PM, Brian Burkhalter <brian.burkhalter at oracle.com> wrote:
> 
> https://bugs.openjdk.java.net/browse/JDK-8131664 <https://bugs.openjdk.java.net/browse/JDK-8131664>
> http://cr.openjdk.java.net/~bpb/8131664/webrev.00/ <http://cr.openjdk.java.net/~bpb/8131664/webrev.00/>
> 
> This patch proposes to clean up some verbiage in java.io <http://java.io/>.PrintStream with respect to the encoding being used to convert chars to bytes.
> 
> Thanks,
> 
> Brian
> 

 <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>





More information about the core-libs-dev mailing list