8073213: javadoc of PushbackInputStream methods should specify NullPointerExceptions

Brian Burkhalter brian.burkhalter at oracle.com
Tue Jul 16 19:45:58 UTC 2019


I changed <code>…</code> to {@code …} and @exception to @throws in [3]. The delta versus the original version [1] is at [2].

Thanks,

Brian

[1] http://cr.openjdk.java.net/~bpb/8073213/webrev.00/
[2] http://cr.openjdk.java.net/~bpb/8073213/webrev.00-01/
[3] http://cr.openjdk.java.net/~bpb/8073213/webrev.01/

> On Jul 16, 2019, at 10:19 AM, Lance Andersen <lance.andersen at oracle.com> wrote:
> 
> +1
>> On Jul 16, 2019, at 12:08 PM, Brian Burkhalter <brian.burkhalter at oracle.com <mailto:brian.burkhalter at oracle.com>> wrote:
>> 
>> https://bugs.openjdk.java.net/browse/JDK-8073213 <https://bugs.openjdk.java.net/browse/JDK-8073213> <https://bugs.openjdk.java.net/browse/JDK-8073213 <https://bugs.openjdk.java.net/browse/JDK-8073213>>
>> 
>> Add javadoc of NPEs missing from two unread() methods; see below.
>> 
>> It would not hurt in this class to also change <code>…</code> to {@code …} and @exception to @throws but that would clutter up the review.



More information about the core-libs-dev mailing list