8067801: Enforce null check for underlying I/O streams

Brian Burkhalter brian.burkhalter at oracle.com
Wed Jul 17 20:39:06 UTC 2019


Hi Lance,

> On Jul 17, 2019, at 1:02 PM, Lance Andersen <lance.andersen at oracle.com> wrote:
> 
> I think what you have is fine, a unique test in each subdirectory as it is organized by class.  What you might consider is having a generic NPE Test class, which validates the error for Constructors and methods as described in the package javadoc.  Maybe this is a TBD, but if you decide that is a good idea, consider renaming the test now to maybe NPETests.java

I merged the two tests into one and converted to TestNG [1]. There is precedent for having a test which deals with multiple classes in test/jdk/java/io [2].

Thanks,

Brian

[1] http://cr.openjdk.java.net/~bpb/8067801/webrev.01/
[2] test/jdk/java/io/NegativeInitSize.java


More information about the core-libs-dev mailing list