Fwd: Re: RFR: 8225648:[TESTBUG] java/lang/annotation/loaderLeak/Main.java fails with -Xcomp

[David Holmes]

Hi Jie,

On 22/07/2019 4:39 pm, Jie Fu wrote:
> Hi David,
> 
> Thanks for correcting me and sorry for that.

No problem, it's a learning curve for everyone.

> Updated: http://cr.openjdk.java.net/~jiefu/8225648/webrev.02/

The patch is still not a proper changeset:

http://cr.openjdk.java.net/~jiefu/8225648/webrev.02/jdk-dev.patch

--- old/test/jdk/java/lang/annotation/loaderLeak/Main.java	2019-07-22 
14:33:23.086509297 +0800
+++ new/test/jdk/java/lang/annotation/loaderLeak/Main.java	2019-07-22 
14:33:22.850508806 +0800
@@ -1,5 +1,5 @@
  /*
- * Copyright (c) 2004, 2012, Oracle and/or its affiliates. All rights 
reserved.
+ * Copyright (c) 2004, 2019, Oracle and/or its affiliates. All rights 
reserved.
   * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
   *
   * This code is free software; you can redistribute it and/or modify it
@@ -56,6 +56,7 @@
          if (c.get() == null) throw new AssertionError();
          System.gc();
          System.gc();
+        Reference.reachabilityFence(loader);
          loader = null;

          // Might require multiple calls to System.gc() for weak-references

Did you use -N when generating the webrev? You shouldn't in this case.

Thanks,
David

> Thanks a lot.
> Best regards,
> Jie
> 
> On 2019/7/22 下午2:22, David Holmes wrote:
>> Hi Jie,
>>
>> On 22/07/2019 4:18 pm, Jie Fu wrote:
>>> Hi all,
>>>
>>> Could someone help to push this: 
>>> http://cr.openjdk.java.net/~jiefu/8225648/webrev.01/ ?
>>> I need a sponsor.
>>
>> To prepare your patch for your sponsor you should commit it with the 
>> correct format commit message, including reviewers, so that the 
>> sponsor can just do an hg import from the URL of the changeset in your 
>> webrev - or somewhere else you point them to.
>>
>> Cheers,
>> David
>>
>>> It had been fully reviewed by Alan and Ioi and can be applied cleanly.
>>>
>>> Thanks a lot.
>>> Best regards,
>>> Jie
>>>
>>>
>>> -------- Forwarded Message --------
>>> Subject:     Re: RFR: 8225648:[TESTBUG] 
>>> java/lang/annotation/loaderLeak/Main.java fails with -Xcomp
>>> Date:     Thu, 20 Jun 2019 12:09:24 +0100
>>> From:     Alan Bateman <Alan.Bateman at oracle.com>
>>> To:     Jie Fu <fujie at loongson.cn>
>>> CC:     core-libs-dev at openjdk.java.net
>>>
>>>
>>>
>>> On 19/06/2019 07:36, Jie Fu wrote:
>>>> Hi Alan,
>>>>
>>>> I've updated the patch by adding the review info.
>>>> http://cr.openjdk.java.net/~jiefu/8225648/webrev.01/
>>>>
>>>> Is it OK to be pushed?
>>> I don't see any objections so go ahead.
>>>
>>> -Alan
>>>
>