[14] RFR: 8212970: TZ database in "vanguard" format support

[naoto.sato at oracle.com]

Thanks for the review, Roger.

On 7/24/19 12:47 PM, Roger Riggs wrote:
> Hi Naoto,
> 
> Adjusting the data during import looks fine.
> 
> Typo:
> 
> TzdbZoneRulesProvider.java:504  "ususally" -> "usually"

Will fix it.

> 
> Removing the source duplication is good.
> 
> Is there a way to remove the duplication of the TZDATA files themselves?
> make/data/tzdata/* and test/jdk/sun/til/calendar/zi/*

I thought about it, but it turned out that the copyright is different 
(with/without classpath exception). So I just leave them as they are.

Naoto

> 
> Looks good,  Roger
> 
> 
> 
> 
> On 7/23/19 6:15 PM, naoto.sato at oracle.com wrote:
>> Hi,
>>
>> Please review the fix to the following enhancement:
>>
>> https://bugs.openjdk.java.net/browse/JDK-8212970
>>
>> The proposed changeset is located at:
>>
>> https://cr.openjdk.java.net/~naoto/8212970/webrev.09/
>>
>> This change aims to support the "vanguard" IANA time zone data format, 
>> which uses the negative savings and transition time beyond a day 
>> period. The change basically translates those negative savings and 
>> transition times, such as 25:00, into the ones that the current JDK 
>> recognizes, then produces the data file "tzdb.dat" at the build time. 
>> At the run time, the data file is read and interpreted as before. This 
>> way the produced tzdb.dat is compatible with the prior JDK releases so 
>> that the TZ Updater can also distribute it as a time zone update.
>>
>> I have also refactored redundant copy of ZoneRules file in the build 
>> directory, by dynamically importing the file under src. Thus some 
>> build related files are modified. I am hoping folks on the build-dev 
>> can review those changes.
>>
>> Naoto
>