RFR: 8228507: Archive FDBigInteger

[Claes Redestad]

Hi Jiangli,

thank you for reviewing! The objects we're dealing with here are all
effectively immutable, however, at least one reference field in
FDBigInteger is non-final, so putting it in a closed archive region is
causing a lot of warnings at dump time. Perhaps we should add a way
to suppress such warnings on a case-by-case basis?

Thanks!

/Claes

On 2019-07-24 20:00, Jiangli Zhou wrote:
> Hi Claes,
> 
> This looks good to me. I wonder if FDBigInteger.archivedCaches could
> be placed in  closed_archive_subgraph_entry_fields for the 'closed'
> archive region? The makeImmutable() is called for the cached
> FDBigInteger objects.
> 
> Best regards,
> Jiangli
> 
> On Wed, Jul 24, 2019 at 2:41 AM Claes Redestad
> <claes.redestad at oracle.com> wrote:
>>
>> Hi,
>>
>> any double<->String conversion will trigger load of
>> jdk.internal.math.FDBigInteger, which has a static
>> initializer pre-calculating a relatively large number
>> of values.
>>
>> Archiving these pre-calculated values reduces the time
>> spent in FDBigInteger.<clinit> from a couple of
>> milliseconds down to "nothing".
>>
>> Bug:    https://bugs.openjdk.java.net/browse/JDK-8228507
>> Webrev: http://cr.openjdk.java.net/~redestad/8228507/open.00/
>>
>> Testing: tier1-3
>>
>> Thanks!
>>
>> /Claes