RFR: JDK-8227684 : jpackage must handle win32 mangled names in jli.dll

Alexander Matveev alexander.matveev at oracle.com
Thu Jul 25 21:29:03 UTC 2019


Do you know if all 32-bit builds will have "_JLI_Launch at 56"?
Also, I think @56 is ordinal which can be used to load function by this 
number instead of the name, so I do not think you need to specify it.

My suggestion is to try "JLI_Launch" first and then "_JLI_Launch" and 
then "_JLI_Launch at 56", if we doing 32-bit build.

Thanks,
Alexander

On 7/25/2019 8:22 AM, Kevin Rushforth wrote:
> It looks fine.
>
> -- Kevin
>
>
> On 7/25/2019 6:20 AM, Andy Herrick wrote:
>> Please review the jpackage fix for bug [1] at [2].
>>
>> This is a fix for the JDK-8200758-branch branch of the open sandbox 
>> repository (jpackage).
>>
>>
>> [1] https://bugs.openjdk.java.net/browse/JDK-8227684
>>
>> [2] http://cr.openjdk.java.net/~herrick/8227684/webrev.01/
>>
>> Submitted by: Robert Lichtenberger
>>
>> /Andy
>>
>



More information about the core-libs-dev mailing list