Review Request: JDK-8209005: Lookup.unreflectSpecial fails for default methods when Lookup.findSpecial works

Mandy Chung mandy.chung at oracle.com
Fri Jul 26 17:41:22 UTC 2019


Daniel noticed that `unreflectSpecial` is missing in the "Lookup Factory 
Methods" section in the class spec.  In fact there are a duplicated 
`lookup.unreflect(aMethod)` row that might originally be for 
`unreflectSpecial`.   I fix the javadoc in this patch:

http://cr.openjdk.java.net/~mchung/jdk14/8209005/webrev.01/

Mandy

On 7/25/19 1:12 PM, Mandy Chung wrote:
> This patch fixes Lookup.unreflectSpecial to pass the declaring class 
> of Method being unreflected (rather than null) so that it can 
> accurately check if the special caller class is either the lookup 
> class or a superinterface of the declaring class.
>
> Webrev:
> http://cr.openjdk.java.net/~mchung/jdk14/8209005/webrev.00/index.html
>
> The test runs in both unnamed module and named module to cover 
> JDK-8209078 which has been resolved by JDK-8173978.
>
> thanks
> Mandy



More information about the core-libs-dev mailing list