Review Request JDK-8222448: java/lang/reflect/PublicMethods/PublicMethodsTest.java times out
David Holmes
david.holmes at oracle.com
Tue Jun 4 05:06:04 UTC 2019
Hi Mandy,
Functional fix looks good, but layout and indentation appears off in the
diff.
Thanks to Alan for the time spent investigating this!
Thanks,
David
On 4/06/2019 1:02 pm, Mandy Chung wrote:
> test/jdk/java/lang/reflect/PublicMethods/PublicMethodsTest.java time out
> in certain configuration e.g. fastdebug -Xcomp. Setting the empty class
> path significantly improves the execution time as it eliminates opening
> and scanning of the JAR files on the class path. Alan has also
> experimented
> it on Windows machine.
>
> diff --git
> a/test/jdk/java/lang/reflect/PublicMethods/PublicMethodsTest.java
> b/test/jdk/java/lang/reflect/PublicMethods/PublicMethodsTest.java
> --- a/test/jdk/java/lang/reflect/PublicMethods/PublicMethodsTest.java
> +++ b/test/jdk/java/lang/reflect/PublicMethods/PublicMethodsTest.java
> @@ -222,6 +222,11 @@
> StandardJavaFileManager standardJavaFileManager =
> javac.getStandardFileManager(errorsCollector, Locale.ROOT,
> Charset.forName("UTF-8"));
> + try {
> + standardJavaFileManager.setLocation(StandardLocation.CLASS_PATH,
> List.of());
> + } catch (IOException e) {
> + throw new UncheckedIOException(e);
> + }
> TestFileManager testFileManager = new TestFileManager(
> standardJavaFileManager, source);
>
>
> Mandy
More information about the core-libs-dev
mailing list