RFR: 6394787: Typos in javadoc of OIS.readObjectOverride and OOS.writeObjectOverride

Chris Hegarty chris.hegarty at oracle.com
Tue Jun 4 08:17:43 UTC 2019


+1 

I can sponsor this for you Andrey.

-Chris.

> On 4 Jun 2019, at 07:56, Alan Bateman <Alan.Bateman at oracle.com> wrote:
> 
> This looks right, I assume a cut&paste issue when the methods were originally added.
> 
> -Alan
> 
> On 02/06/2019 12:23, Andrey Turbanov wrote:
>> Hello.
>> I would like to contribute a small patch for bug:
>> https://bugs.openjdk.java.net/browse/JDK-6394787
>> 
>> Index: src/java.base/share/classes/java/io/ObjectOutputStream.java
>> IDEA additional info:
>> Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
>> <+>UTF-8
>> ===================================================================
>> --- src/java.base/share/classes/java/io/ObjectOutputStream.java
>> (revision 640ffa0674929c4416a0f562be2bf404c580474b)
>> +++ src/java.base/share/classes/java/io/ObjectOutputStream.java
>> (date 1559474301051)
>> @@ -1,5 +1,5 @@
>>  /*
>> - * Copyright (c) 1996, 2017, Oracle and/or its affiliates. All rights reserved.
>> + * Copyright (c) 1996, 2019, Oracle and/or its affiliates. All rights reserved.
>>   * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
>>   *
>>   * This code is free software; you can redistribute it and/or modify it
>> @@ -357,8 +357,8 @@
>> 
>>      /**
>>       * Method used by subclasses to override the default writeObject method.
>> -     * This method is called by trusted subclasses of ObjectInputStream that
>> -     * constructed ObjectInputStream using the protected no-arg constructor.
>> +     * This method is called by trusted subclasses of ObjectOutputStream that
>> +     * constructed ObjectOutputStream using the protected no-arg constructor.
>>       * The subclass is expected to provide an override method with the modifier
>>       * "final".
>>       *
>> Index: src/java.base/share/classes/java/io/ObjectInputStream.java
>> IDEA additional info:
>> Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
>> <+>UTF-8
>> ===================================================================
>> --- src/java.base/share/classes/java/io/ObjectInputStream.java
>> (revision 640ffa0674929c4416a0f562be2bf404c580474b)
>> +++ src/java.base/share/classes/java/io/ObjectInputStream.java
>> (date 1559472438350)
>> @@ -447,8 +447,8 @@
>>      }
>> 
>>      /**
>> -     * This method is called by trusted subclasses of ObjectOutputStream that
>> -     * constructed ObjectOutputStream using the protected no-arg constructor.
>> +     * This method is called by trusted subclasses of ObjectInputStream that
>> +     * constructed ObjectInputStream using the protected no-arg constructor.
>>       * The subclass is expected to provide an override method with the modifier
>>       * "final".
>>       *
>> Index: test/jdk/java/io/Serializable/subclass/AbstractObjectOutputStream.java
>> IDEA additional info:
>> Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
>> <+>UTF-8
>> ===================================================================
>> --- test/jdk/java/io/Serializable/subclass/AbstractObjectOutputStream.java
>>    (revision 640ffa0674929c4416a0f562be2bf404c580474b)
>> +++ test/jdk/java/io/Serializable/subclass/AbstractObjectOutputStream.java
>>    (date 1559474030191)
>> @@ -1,5 +1,5 @@
>>  /*
>> - * Copyright (c) 1998, 2004, Oracle and/or its affiliates. All rights reserved.
>> + * Copyright (c) 1998, 2019, Oracle and/or its affiliates. All rights reserved.
>>   * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
>>   *
>>   * This code is free software; you can redistribute it and/or modify it
>> @@ -44,7 +44,7 @@
>>   *
>>   * Since serialization must override java access rules in order to
>>   * access private, protected and package accessible Serializable fields,
>> - * only trusted classes are allowed to subclass AbstractObjectInputStream.
>> + * only trusted classes are allowed to subclass AbstractObjectOutputStream.
>>   * Subclasses of AbstractObjectOututStream must have SerializablePermission
>>   * "enableAbstractSubclass" or this constructor will throw a
>>   * SecurityException.Implementations of this class should protect themselves
>> 
>> 
>> Andrey Turbanov
> 



More information about the core-libs-dev mailing list