Review Request JDK-8221368: Error message when module main class cannot be loaded is missing exception details

Mandy Chung mandy.chung at oracle.com
Tue Jun 4 18:34:23 UTC 2019


Alan, Sundar,

Thanks for the review.

I further clean up the test and rename jdk.test.Main2 class to a new 
test2 module.  No change to the fix.

http://cr.openjdk.java.net/~mchung/jdk13/webrevs/8221368/webrev.01/

Mandy

On 6/4/19 12:10 AM, Alan Bateman wrote:
> On 04/06/2019 05:00, Mandy Chung wrote:
>> The launcher prints out the error message when the main class fails to
>> initialize but java.launcher.module.error5 resource that intends to
>> print the Caused-by exception message when running in a named module
>> but prints an incorrect parameter.
>>
>> Very simple fix - fix the resource param indices.  Also fix a
>> typo: "module module <module-name>" in the output.
>>
>> http://cr.openjdk.java.net/~mchung/jdk13/webrevs/8221368/webrev.00/
>>
>> The error message when the main class is in an unnamed module
>> is printed properly and covered by an existing test
>> (test/jdk/tools/launcher/MainClassCantBeLoadedTest.java).
>>
> This looks good.
>
> -Alan
>



More information about the core-libs-dev mailing list