RFR: 8224974: Implement JEP 352

[Brian Burkhalter]

Hi Andrew,

> On Jun 6, 2019, at 1:53 AM, Andrew Dinn <adinn at redhat.com> wrote:
> 
> […]
> 
> I have updated webrev.06 in place and PmemTest now runs ok. I still need
> to have Jonathan Halliday test the patch with our Transaction and Data
> Grid software before it can be properly signed off. Another submit run
> will also be needed. However, PmemTest is a good enough sanity check to
> validate the changes you requested.
> 
> So, here is webrev.06 as the latest official patch:
> 
>  http://cr.openjdk.java.net/~adinn/8224974/webrev.06/ <http://cr.openjdk.java.net/~adinn/8224974/webrev.06/>

I am running it through our tests now.

> It should address
> 
>  […]
> 
> The last of those changes still leaves one issue unanswered (although it
> may not actually be an issue). Vladimir is probably best able to comment.
> 
> When I run CheckGraalIntrinsics (which is actually run indirectly by
> compiler/graalunit/HotspotTest) with my patched tree it fails, claiming
> that Graal does not know about Unsafe.writeback0:
> 
>  java.lang.AssertionError: missing Graal intrinsics for:
>      jdk/internal/misc/Unsafe.writeback0(J)V
> 
> I am assuming this is what is expected to happen? Or perhaps the test is
> supposed to be added to the problem or exclude lists?

I’ll leave it to Vladimir or someone else more knowledgeable than I to comment on this area.

>> Sorry for suggesting the change that was the proximate cause of this. :-(
> No problem :-) Thanks for reviewing and checking!

You are welcome!

Cheers,

Brian