RFR: JDK-8224130: create additional automated tests for create-app-image

Andy Herrick andy.herrick at oracle.com
Thu Jun 6 21:45:58 UTC 2019


revised to use Files.newBufferedWriter() in 
JPackageHelper.cmdWithAtFilename() as suggested.

webrev: http://cr.openjdk.java.net/~herrick/8224130/webrev.02/

/Andy


On 6/6/2019 1:03 PM, Alexey Semenyuk wrote:
> http://cr.openjdk.java.net/~herrick/8224130/webrev.01/test/jdk/tools/jpackage/helpers/JPackageHelper.java.sdiff.html: 
>
> ---
>  try (PrintWriter out = new PrintWriter(new BufferedWriter(
>  520                     new FileWriter("argfile.cmds")))) {
>  521                 out.println(fileString);
>  522             }
> ---
> I suggest to use Files.newBufferedWriter() call instead of new 
> BufferedWriter(new FileWriter...)).
>
> -Alexey
>
> On 6/5/2019 8:07 PM, Andy Herrick wrote:
>> Please review the jpackage fix for bug [1] at [2].
>>
>> This is a fix for the JDK-8200758-branch branch of the open sandbox 
>> repository (jpackage).
>>
>> [1] https://bugs.openjdk.java.net/browse/JDK-8224130
>> [2] http://cr.openjdk.java.net/~herrick/8224130/
>>
>> /Andy
>>
>



More information about the core-libs-dev mailing list