RFR: 8224974: Implement JEP 352

Andrew Dinn adinn at redhat.com
Fri Jun 7 11:24:33 UTC 2019


On 06/06/2019 18:40, Vladimir Kozlov wrote:
> Hotspot changes looks good.
> 
> CheckGraalIntrinsics failed because of typo - you should use 'J' instead
> of 'L':
> 
> +  "jdk/internal/misc/Unsafe.writeback0(L)V",

Doh! Thanks, Vladimir :-)

With that correction the test now passes.

> One nitpick in vmSymbols.hpp spacing is off in next line:
> 
> +  do_intrinsic(_writebackPostSync0,       
> jdk_internal_misc_Unsafe,     writebackPostSync0_name,
> void_method_signature , F_RN)   \
That line and the one two lines further on were both misaligned.

I have uploaded a new webrev to fix the bove problems. This version also
removes all the extra extraneous whitespace found by Brian and Gustavo.

  webrev: http://cr.openjdk.java.net/~adinn/8224974/webrev.07/

I have posted the changes to the submit repo to re-verify that all
builds pass. I have also asked Jonathan Halliday to re-test this version
against the Red Hat middleware clients to ensure there are no functional
or performance changes.

Modulo confirmation of those two checks this looks like it is a complete
implementation. Unless anyone has more changes to recommend?

regards,


Andrew Dinn
-----------
Senior Principal Software Engineer
Red Hat UK Ltd
Registered in England and Wales under Company Registration No. 03798903
Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander


More information about the core-libs-dev mailing list