JDK 13 RFR of JDK-8225675: Outdated citation of JLS in java.lang.ref.Reference

Mandy Chung mandy.chung at oracle.com
Wed Jun 12 20:50:59 UTC 2019


Looks good.  Thanks for fixing it.

Mandy

On 6/12/19 1:35 PM, Joe Darcy wrote:
> Hello,
>
> Please review the small patch below to address
>
>     JDK-8225675: Outdated citation of JLS in java.lang.ref.Reference
>
> (I'll reflow the paragraph before pushing; wanted to make the nature 
> of the diff clearer in the review.)
>
> Thanks,
>
> -Joe
>
> diff -r 1224b16c8ff4 
> src/java.base/share/classes/java/lang/ref/Reference.java
> --- a/src/java.base/share/classes/java/lang/ref/Reference.java Wed Jun 
> 12 12:31:32 2019 -0700
> +++ b/src/java.base/share/classes/java/lang/ref/Reference.java Wed Jun 
> 12 13:30:43 2019 -0700
> @@ -419,8 +419,8 @@
>       * facilities are not possible or do not provide the desired 
> control.  This
>       * method is applicable only when reclamation may have visible 
> effects,
>       * which is possible for objects with finalizers (See
> -     * <a 
> href="https://docs.oracle.com/javase/specs/jls/se8/html/jls-12.html#jls-12.6">
> -     * Section 12.6 17 of <cite>The Java™ Language 
> Specification</cite></a>)
> +     * Section 12.6 of <cite>The Java™ Language
> +     * Specification</cite>)
>       * that are implemented in ways that rely on ordering control for 
> correctness.
>       *
>       * @apiNote
> @@ -508,6 +508,7 @@
>       *
>       * @param ref the reference. If {@code null}, this method has no 
> effect.
>       * @since 9
> +     * @jls 12.6 Finalization of Class Instances
>       */
>      @ForceInline
>      public static void reachabilityFence(Object ref) {
>



More information about the core-libs-dev mailing list