RFR: 8225648:[TESTBUG] java/lang/annotation/loaderLeak/Main.java fails with -Xcomp

Ioi Lam ioi.lam at oracle.com
Thu Jun 13 07:48:57 UTC 2019


Hi Jie,

Instead of using an obscure call Reference.reachabilityFence(loader), 
how about just making "loader" a static field in the test class, so it 
will be kept alive until it's explicitly set to null?

Thanks
- Ioi

On 6/12/19 1:37 AM, Jie Fu wrote:
> Hi all,
>
> JBS:    https://bugs.openjdk.java.net/browse/JDK-8225648
> Webrev: http://cr.openjdk.java.net/~jiefu/8225648/webrev.00/
>
> The failure was caused by the lost of an OopMap item for the object 
> "loader"[1] which was optimized out by JIT with liveness analysis 
> optimization.
> It seems that this case is only suitable for testing interpreters 
> which is not friendly to optimized JITs at all.
>
> Although not every test would work with Xcomp (for various reasons), 
> it's beneficial to make more tests suitable for JIT testing.
> I just hope tests in tier1 would pass with Xcomp.
> The goal seems to be reached if this bug and JDK-8225644[2] could be 
> fixed.
>
> Could you please review it?
>
> Thanks a lot.
> Best regards,
> Jie
>
> [1] 
> http://hg.openjdk.java.net/jdk/jdk/file/ae3dbc712839/test/jdk/java/lang/annotation/loaderLeak/Main.java#l48
> [2] https://bugs.openjdk.java.net/browse/JDK-8225644
>
>



More information about the core-libs-dev mailing list