RFR: JDK-8225569: jpackage app-image layout

[Alexander Matveev]

Hi Andy,

1) I think it is better to move mksure() to common place like IOUtils, 
otherwise it is duplicated in WindowsAppImageBuilder.java and 
LinuxAppImageBuilder.java.

2) For Alexey comment I think it is good idea to use Paths.get(), but I 
think it should be done as separate cleanup bug.

Otherwise looks good.

Thanks,
Alexander

On 6/13/2019 11:00 AM, Alexey Semenyuk wrote:
> Looks good.
>
> Q: any good reason we are not using
> Paths.get(a, b, c)
> instead of
> a + File.separator + b + File.separator + c
> to build paths?
>
> - Alexey
>
> On 6/13/2019 1:21 PM, Andy Herrick wrote:
>>
>> Sorry - subject was missing, this is for: JDK-8225569: jpackage 
>> app-image layout
>>
>> /Andy
>>
>> On 6/13/2019 12:59 PM, Andy Herrick wrote:
>>> Please review the jpackage fix for bug [1] at [2].
>>>
>>> This is a fix for the JDK-8200758-branch branch of the open sandbox 
>>> repository (jpackage).
>>>
>>> [1] https://bugs.openjdk.java.net/browse/JDK-8225569
>>> [2] http://cr.openjdk.java.net/~herrick/8225569/webrev.01/ 
>>> <http://cr.openjdk.java.net/%7Eherrick/8225569/webrev.01/>
>>>
>>> /Andy
>>>
>>
>