RFR: JDK-8225569: jpackage app-image layout

Alexander Matveev alexander.matveev at oracle.com
Fri Jun 14 22:14:34 UTC 2019


Looks good.

On 6/14/2019 8:54 AM, Andy Herrick wrote:
>
>
> On 6/14/2019 11:44 AM, Kevin Rushforth wrote:
>> Looks good.
>>
>> Btw, there is a trailing whitespace you might want to fix (although 
>> that can be done later as a bulk update if you prefer).
>>
>> test/jdk/tools/jpackage/createappimage/JPackageCreateAppImageBase.java:50: 
>> Trailing whitespace
>>
> will fix this one before push.
> /Andy
>> -- Kevin
>>
>>
>> On 6/14/2019 7:17 AM, Andy Herrick wrote:
>>> Please review the revised jpackage fix [3] for issue [1]
>>>
>>> revised to use Path.of() in JPackagePath test helper and to 
>>> centralize code that creates output dirs and/or makes sure they are 
>>> empty and writable.
>>>
>>> [3] http://cr.openjdk.java.net/~herrick/8225569/webrev.02/
>>>
>>>
>>> /Andy
>>>
>>> On 6/13/2019 1:21 PM, Andy Herrick wrote:
>>>>
>>>> Sorry - subject was missing, this is for: JDK-8225569: jpackage 
>>>> app-image layout
>>>>
>>>> /Andy
>>>>
>>>> On 6/13/2019 12:59 PM, Andy Herrick wrote:
>>>>> Please review the jpackage fix for bug [1] at [2].
>>>>>
>>>>> This is a fix for the JDK-8200758-branch branch of the open 
>>>>> sandbox repository (jpackage).
>>>>>
>>>>> [1] https://bugs.openjdk.java.net/browse/JDK-8225569
>>>>> [2] http://cr.openjdk.java.net/~herrick/8225569/webrev.01/ 
>>>>> <http://cr.openjdk.java.net/%7Eherrick/8225569/webrev.01/>
>>>>>
>>>>> /Andy
>>>>>
>>>>
>>>
>>
>



More information about the core-libs-dev mailing list